Add reboot-delay command line argument
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, kured issues the system reboot command immediately after kubectl drain finishes. This is a problem for processes that need extra time to finish but aren't running on pods and therefore aren't controlled by kubectl drain (e.g. de-registering nodes from external load balancers). This patch solves the problem by introducing a `reboot-delay` command line argument that can be used to add a delay after kubectl drain finishes but before the reboot command is issued.
|
(I released the e2e checks that were waiting for approval.) Thanks again! |
|
Thanks for splitting your PR in two! I will have a look and think of all the things good and bad about this. Eventually. (yes that's my sense of humour!) |
|
I realise now it's missing documentation and changes into helm chart + manifest. Could you do a PR for that @amorey ? |
|
No prob #430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, kured issues the system reboot command immediately after
kubectl drain finishes.
This is a problem for processes that need extra time to finish but aren't
running on pods and therefore aren't controlled by kubectl drain (e.g.
de-registering nodes from external load balancers).
This patch solves the problem by introducing a
reboot-delaycommandline argument that can be used to add a delay after kubectl drain
finishes but before the reboot command is issued.